Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssm-agent: 2.0.633.0 -> 2.3.1319.0 #91586

Merged
merged 1 commit into from Aug 23, 2020
Merged

ssm-agent: 2.0.633.0 -> 2.3.1319.0 #91586

merged 1 commit into from Aug 23, 2020

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Jun 26, 2020 •
edited

Motivation for this change

The SSM agent doesn't work anymore on EC2.

Bumping version and switching to Amazon's executable names for less conflicts with other agent executables.
To bring the ssm-agent up to date and support new features like AWS Session Manager and SSM SSH.

This is basically a newer version of #74384 which was never merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from copumpkin June 26, 2020 10:35
@manveru manveru force-pushed the amazon-ssm-agent-2.3.1319.0 branch from 94b0488 to d1c4bf9 Compare June 26, 2020 10:43
@manveru
Copy link
Contributor Author

manveru commented Jun 26, 2020

@GrahamcOfBorg build ssm-agent

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/263

@Lassulus Lassulus merged commit 4165f98 into NixOS:master Aug 23, 2020
@Lassulus Lassulus mentioned this pull request Aug 23, 2020
Closed
10 tasks
@lbodor
Copy link
Contributor

lbodor commented Aug 24, 2020

Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manveru @nixos-discourse @lbodor @Lassulus