Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] libtomcrypt: fix CVE-2019-17362 (security, backport) #91522

Merged
merged 1 commit into from Jun 29, 2020
Merged

[20.03] libtomcrypt: fix CVE-2019-17362 (security, backport) #91522

merged 1 commit into from Jun 29, 2020

Conversation

wamserma
Copy link
Member

(cherry picked from commit 5f16eca)

Motivation for this change

#90860

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wamserma
libtomcrypt: fix CVE-2019-17362 (security)
05c4441 
(cherry picked from commit 5f16eca)
@mmilata mmilata added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. labels Jun 25, 2020
@wamserma
Copy link
Member Author

ping @nh2

@nh2
Copy link
Contributor

nh2 commented Jun 29, 2020

Result of nixpkgs-review pr 91522 1

1 package failed to build:
- bitkeeper
1 package built:
- libtomcrypt

@wamserma
Copy link
Member Author

wamserma commented Jun 29, 2020 •
edited

bitkeeper is marked as broken

@nh2
Copy link
Contributor

nh2 commented Jun 29, 2020

bitkeeper is marked as broken

Yes also doesn't compile before the commit, so this PR does not regress it.

@nh2 nh2 merged commit 1cf3aff into NixOS:release-20.03 Jun 29, 2020
@wamserma wamserma deleted the libtomcrypt-cve-2019-17362-backport branch June 29, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wamserma @nh2 @mmilata