Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtomcrypt: fix CVE-2019-17362 (security) #91520

Merged
merged 1 commit into from Jun 28, 2020
Merged

libtomcrypt: fix CVE-2019-17362 (security) #91520

merged 1 commit into from Jun 28, 2020

Conversation

wamserma
Copy link
Member

@wamserma wamserma commented Jun 25, 2020 •
edited

Motivation for this change

Closes #90860

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

mweinelt commented Jun 26, 2020 •
edited

Result of nixpkgs-review pr 91520 1

1 package failed to build:
- bitkeeper 
error: Package ‘bitkeeper-7.3.1ce’ in /home/hexa/git/nixos/master/pkgs/applications/version-management/bitkeeper/default.nix:45 is marked as broken, refusing to evaluate.
1 package built:
- libtomcrypt

@wamserma
Copy link
Member Author

bitkeeper was already broken before.

$ ./hydra-status-unstable.sh bitkeeper
Last status of bitkeeper = Failed

@mweinelt
Copy link
Member

mweinelt commented Jun 26, 2020 via email

@wamserma
Copy link
Member Author

Which is why I approved the pull request.

Just wanted to have it on record here for anyone else stumbling on this.

@nh2 nh2 merged commit 749788b into NixOS:master Jun 28, 2020
@wamserma wamserma deleted the fix-libtomcrypt-cve-2019-17362 branch June 28, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 85: libtomcrypt-1.18.2: 1 advisory [9.1]
4 participants
@wamserma @mweinelt @mmilata @nh2