Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudCompare, pdal, libe57format, MeshLabXML #91523

Merged
merged 7 commits into from Jun 26, 2020
Merged

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jun 25, 2020

Motivation for this change

This adds various 3D point cloud processing tools, including CloudCompare, one of the main point cloud GUI softwares.

Required for that:

Also:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've tested tested running CloudCompare on Ubuntu with nixGL, built on a NixOS builder. @chpatrick has run it on NixOS desktop.

MeshLabXML is only packaged, and not significantly tested (but that is fine).

pkgs/applications/graphics/cloudcompare/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/LASzip/LASzip2.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/LASzip/LASzip2.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/pdal/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/MeshLabXML/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/MeshLabXML/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/MeshLabXML/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/MeshLabXML/default.nix Outdated Show resolved Hide resolved
@nh2 nh2 force-pushed the cloudcompare-2.11.0 branch 2 times, most recently from 1d51f3a to 04d7618 Compare June 25, 2020 23:05
@nh2
Copy link
Contributor Author

nh2 commented Jun 25, 2020

@jonringer Thanks, much appreciated. I have incorporated all feedback.

@nh2 nh2 force-pushed the cloudcompare-2.11.0 branch 3 times, most recently from 6a833f0 to e485a7b Compare June 26, 2020 00:17
@nh2
Copy link
Contributor Author

nh2 commented Jun 26, 2020

Result of nixpkgs-review pr 91523 1

10 packages built:
- LASzip
- LASzip2
- cloudcompare
- grass
- libLAS
- libe57format
- pdal
- python27Packages.meshlabxml
- python37Packages.meshlabxml
- python38Packages.meshlabxml

@nh2 nh2 merged commit 28ea6a7 into NixOS:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants