Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde-applications: 19.12.3 -> 20.04.1 #91571

Merged
merged 13 commits into from Jul 14, 2020
Merged

kde-applications: 19.12.3 -> 20.04.1 #91571

merged 13 commits into from Jul 14, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Also includes the required kde-frameworks update from 5.68 to 5.71.

So far okular, gwenview and okular are working (the ones that I care
about the most) but nix-review is currently running.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg requested a review from ttuegel as a code owner June 26, 2020 08:53
@peterhoeg
Copy link
Member Author

Should probably be merged together with #84542 to avoid double rebuilds.

@DIzFer
Copy link
Contributor

DIzFer commented Jun 27, 2020

I agree on updating all of KDE all at once at this point, but if the target plasma is 5.18 (as in the mentioned PR), I'd rather include a certain revert that fixes animation speeds being slow (8fb203c6b2d).

Alternatively, skip 5.18 altogether, wait until 5.19 is ready to merge, and skip patching frameworks during the 5 minutes it would be needed (probably the way to go)

ttuegel
ttuegel approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

I don't have an opinion about merging this with Plasma or not. To be honest, rebuilding Frameworks + Plasma just isn't that big compared to some other ecosystems. If the Plasma update is about ready, then let's merge them both, but I wouldn't want to see this get hung up (and outdated) based on updating Plasma.

@peterhoeg peterhoeg marked this pull request as draft July 1, 2020 14:41
@peterhoeg
Copy link
Member Author

This is quite ready - a number of packages need patches of various kinds to work.

@ttuegel
Copy link
Member

ttuegel commented Jul 13, 2020

I fixed the patches for kcmutils which were causing that build to fail. (The offending patch was no longer needed.) I pushed the changes to the branch.

@ofborg ofborg bot requested a review from ttuegel July 13, 2020 17:03
@ofborg ofborg bot requested a review from nyanloutre July 13, 2020 19:15
@ttuegel
Copy link
Member

ttuegel commented Jul 13, 2020

All KDE Frameworks and Applications now build.

@ttuegel
Copy link
Member

ttuegel commented Jul 13, 2020

The NixOS Plasma test is also passing.

@ttuegel ttuegel marked this pull request as ready for review July 14, 2020 14:47
ttuegel
ttuegel approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All KDE Applications build and run. It's not possible for me to do detailed functional testing of each application, but the sooner we have this in the unstable branch, the sooner we can root out any problems.

@ofborg ofborg bot requested a review from ttuegel July 14, 2020 15:21
@ttuegel ttuegel merged commit 7a8bdde into master Jul 14, 2020
@peterhoeg peterhoeg deleted the u/kde branch July 22, 2020 03:20
@peterhoeg
Copy link
Member Author

Thanks for cleaning this up @ttuegel. I realize that I meant to say "This is not quite ready yet" earlier.... Language is hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @DIzFer @ttuegel