Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mame: 0.221 -> 0.222 #91618

Merged
merged 2 commits into from Jun 27, 2020
Merged

mame: 0.221 -> 0.222 #91618

merged 2 commits into from Jun 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 26, 2020 •
edited by ghost

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from abbradar June 26, 2020 16:18
danieldk
danieldk suggested changes Jun 27, 2020
View reviewed changes
pkgs/misc/emulators/mame/default.nix Outdated Show resolved Hide resolved
@danieldk
Update pkgs/misc/emulators/mame/default.nix
bb0ec28 
Fix hash

Co-authored-by: Daniël de Kok <me@github.danieldk.eu>
danieldk
danieldk approved these changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 91618 1

1 package built:
- mame

mame64 binary runs as expected. Thanks!

@danieldk danieldk merged commit 5cee53c into NixOS:master Jun 27, 2020
@danieldk
Copy link
Contributor

Jikes, missed that the hash change was now a separate commit. The commits should've been squashed into once. Better luck next time!

@ghost ghost deleted the mame branch June 27, 2020 10:00
@ghost
Copy link
Author

ghost commented Jun 27, 2020

@danieldk Thank you!

@ghost ghost removed the request for review from abbradar August 7, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danieldk