Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slurm: minor bugfixes #91578

Merged
merged 2 commits into from Jun 26, 2020
Merged

slurm: minor bugfixes #91578

merged 2 commits into from Jun 26, 2020

Conversation

markuskowa
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
slurm: remove obsolete dependencies
335c487 
libssh and openssl are not required anymore
@markuskowa
slurm: add patch to allow full path lengths in --get-user-env
b8703b4 
Fix fallout from NixOS#90041
and 5d8f61f, which fixes
the crash of slurmd but "sbatch --get-user-env" did not work
properly.
@ofborg ofborg bot requested a review from jagajaga June 26, 2020 09:42
@markuskowa markuskowa merged commit 8828a1d into NixOS:master Jun 26, 2020
@markuskowa markuskowa deleted the fix-slurm branch June 26, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@markuskowa