Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: apply patch for CVE-2020-10753 #91602

Merged
merged 1 commit into from Jun 26, 2020
Merged

ceph: apply patch for CVE-2020-10753 #91602

merged 1 commit into from Jun 26, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

[oss-security] CVE-2020-10753 ceph: radosgw: HTTP header injection via CORS ExposeHeader tag

https://www.openwall.com/lists/oss-security/2020/06/25/5

Fixes: CVE-2020-10753

I'm not familiar with this package, but the patch applied cleanly and the single- and multi-node tests are working.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adevress @wkennington @krav @johanot

@ofborg ofborg bot requested review from adevress, johanot and krav June 26, 2020 13:05
@mweinelt
Copy link
Member Author

20.03 uses the same version, so if this is fine we can easily backport it.

@johanot
Copy link
Contributor

johanot commented Jun 26, 2020

cc @srhb

@srhb srhb self-assigned this Jun 26, 2020
@srhb
Copy link
Contributor

srhb commented Jun 26, 2020

Thanks!

@srhb srhb merged commit 1c3b674 into NixOS:master Jun 26, 2020
@mweinelt mweinelt deleted the ceph branch June 26, 2020 13:40
srhb pushed a commit to srhb/nixpkgs that referenced this pull request Jun 26, 2020
@mweinelt @srhb
ceph: apply patch for CVE-2020-10753
d05652b 
Fixes: CVE-2020-10753
(cherry picked from commit f76a83c)

Backport of NixOS#91602
@mweinelt mweinelt mentioned this pull request Jun 26, 2020
Merged
10 tasks
@srhb srhb mentioned this pull request Jun 26, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adevress adevress Awaiting requested review from adevress

@johanot johanot Awaiting requested review from johanot

@krav krav Awaiting requested review from krav

Assignees

@srhb srhb

Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mweinelt @johanot @srhb @mmilata