Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing WebKitGTK runs since June 22 #24360

Closed
LukeZielinski opened this issue Jun 26, 2020 · 4 comments · Fixed by #24576
Closed

Missing WebKitGTK runs since June 22 #24360

LukeZielinski opened this issue Jun 26, 2020 · 4 comments · Fixed by #24576

Comments

@LukeZielinski
Copy link
Contributor

As per https://wpt.fyi/runs?label=master&label=experimental&max-count=100&product=chrome&product=edge&product=firefox&product=safari&product=webkitgtk the last successful WebKitGTK run was June 22 (4 days ago).

Any idea what's going on?

@jdm
Copy link
Contributor

jdm commented Jun 26, 2020

This is the same as #24257:

 0:14.49 INFO Running print-reftest tests
 0:14.50 ERROR Unsupported test type print-reftest for product webkitgtk_minibrowser
 0:14.50 INFO Got 0 unexpected results
 0:14.50 SUITE_END

@clopez
Copy link
Contributor

clopez commented Jun 29, 2020

This is the same as #24257:

Yes.. same issue.

We need to avoid failing the taskcluster CI run if the browser doesn't support the print-reftest tests (or skip those tests)

@stephenmcgruer
Copy link
Contributor

To keep things synced - it seems like nobody currently owns #24257, so if there's a desire to get WebKitGTK back on wpt.fyi someone needs to step up and add 'skip if not supported' logic or something similar to that.

@clopez
Copy link
Contributor

clopez commented Jul 13, 2020

To keep things synced - it seems like nobody currently owns #24257, so if there's a desire to get WebKitGTK back on wpt.fyi someone needs to step up and add 'skip if not supported' logic or something similar to that.

Thanks for the heads up. There is definitively a desire to get WebKitGTK back on wpt.fyi. I have a patch that I think it can work. .. will upload the PR now

clopez added a commit to clopez/wpt that referenced this issue Jul 13, 2020
* print-reftests are currently not supported for this two browsers.
So we need to avoid triggering those runs on taskcluster for them to
avoid failing the whole run. This fixes: web-platform-tests#24360 and web-platform-tests#24257.
* This patch removes the print-reftest suite from the general block
and adds a new block for it and for the browsers that support this
tests on taskcluster (chrome and firefox).
clopez added a commit to clopez/wpt that referenced this issue Jul 13, 2020
…#24576)

* print-reftests are currently not supported for this two browsers.
So we need to avoid triggering those runs on taskcluster for them to
avoid failing the whole run. This fixes: web-platform-tests#24360 and web-platform-tests#24257.
* This patch removes the print-reftest suite from the general block
and adds a new block for it and for the browsers that support this
tests on taskcluster (Chrome and Firefox).
clopez added a commit that referenced this issue Jul 13, 2020
* print-reftests are currently not supported for this two browsers.
So we need to avoid triggering those runs on taskcluster for them to
avoid failing the whole run. This fixes: #24360 and #24257.
* This patch removes the print-reftest suite from the general block
and adds a new block for it and for the browsers that support this
tests on taskcluster (Chrome and Firefox).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants