Augment iframe lazyload tests for srcdoc #24361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
deniak,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
|
Actually I'm going to refactor this test to make better - please hold off on reviewing until my next comment, sorry |
|
OK that was quicker than expected. I've broken the one test in this file into four tests, which is much cleaner I think. PTAL! |
|
Ping |
scott-little
approved these changes
Jun 30, 2020
html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy.tentative.html
Show resolved
Hide resolved
|
I realized Scott doesn't have the access to this repo to authoritatively review PRs, so I'm closing this and landing it at https://chromium-review.googlesource.com/c/chromium/src/+/2276624. |
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jul 1, 2020
This PR augments the existing iframe lazyload test for srcdoc lazyload support. Chrome currently does not implement this. The test accompanies the spec change made at: whatwg/html#5579. I am TBR'ing this because sclittle@ already reviewed this at #24361, but doesn't have the permissions to submit an "authoritative" review over there. TBR=sclittle@chromium.org Bug: 1101170 Change-Id: I5c5790c5d2eca3efbb01c5470e2267f2265858f6
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jul 1, 2020
This CL augments the existing iframe lazyload test for srcdoc lazyload support. Chrome currently does not implement this. The test accompanies the spec change made at: whatwg/html#5579. I am TBR'ing this because sclittle@ already reviewed this at #24361, but doesn't have the permissions to submit an "authoritative" review over there. TBR=sclittle@chromium.org Bug: 1101170 Change-Id: I5c5790c5d2eca3efbb01c5470e2267f2265858f6
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jul 1, 2020
This CL augments the existing iframe lazyload test for srcdoc lazyload support. Chrome currently does not implement this. The test accompanies the spec change made at: whatwg/html#5579. I am TBR'ing this because sclittle@ already reviewed this at #24361, but doesn't have the permissions to submit an "authoritative" review over there. TBR=sclittle@chromium.org Bug: 1101170 Change-Id: I5c5790c5d2eca3efbb01c5470e2267f2265858f6
|
@stephenmcgruer can you give @scott-little the right access? |
Invitation sent. |
|
LGTM (except #24471) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR augments the existing iframe lazyload test for
srcdoclazyload supportwhatwg/html#5579