Use text-underline-offset in painting text decorations #24356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 26, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2232980
branch
2 times, most recently
from
33d55b6
to
e6980da
Compare
After parsing support for text-underline-offset [1], incorporate the parsed value into decoration painting. Allow nesting of text-underline-offset values by keeping track of them in AppliedTextDecoration, analogously to how text-decoration-thickness is stored. Add a manual WPT test for ensuring that nesting of text-underline-offset paints correctly. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2148786 Bug: 785230 Change-Id: I302f43527f38c7fdfea3cb0e82b6a7a44ed02133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232980 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#783461}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2232980
branch
from
e6980da
to
ded1550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After parsing support for text-underline-offset [1], incorporate the
parsed value into decoration painting.
Allow nesting of text-underline-offset values by keeping track of them
in AppliedTextDecoration, analogously to how text-decoration-thickness
is stored.
Add a manual WPT test for ensuring that nesting of text-underline-offset
paints correctly.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2148786
Bug: 785230
Change-Id: I302f43527f38c7fdfea3cb0e82b6a7a44ed02133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232980
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#783461}