Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages: cleaning up obsolete overrides (3/x) #91513

Merged
merged 1 commit into from Jun 26, 2020
Merged

haskellPackages: cleaning up obsolete overrides (3/x) #91513

merged 1 commit into from Jun 26, 2020

Conversation

svmhdvn
Copy link
Contributor

@svmhdvn svmhdvn commented Jun 25, 2020

Motivation for this change

Remove obsolete overrides on the following haskellPackages:

  • euler: -dontCheck
  • snappy-framing: -dontHaddock
  • vector: -dontCheck

Part of #86500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@svmhdvn
haskellPackages: remove obsolete overrides
55da2e3 
euler: -dontCheck
snappy-framing: -dontHaddock
vector: -dontCheck
@svmhdvn svmhdvn changed the title haskellPackages: remove obsolete overrides haskellPackages: cleaning up obsolete overrides (3/x) Jun 25, 2020
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.euler
@GrahamcOfBorg build haskellPackages.snappy-framing
@GrahamcOfBorg build haskellPackages.vector

@cdepillabout
Copy link
Member

Building at least on Linux, thanks!

@cdepillabout cdepillabout merged commit 72ad5b7 into NixOS:haskell-updates Jun 26, 2020
@svmhdvn svmhdvn deleted the overrides-3 branch June 27, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svmhdvn @cdepillabout