Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: postgresqlPackages.multicorn: init at 1.4.0 #91510

Closed
wants to merge 1 commit into from
Closed

WIP: postgresqlPackages.multicorn: init at 1.4.0 #91510

wants to merge 1 commit into from

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jun 25, 2020

Motivation for this change

In the nixos test, CREATE EXTENSION works but not the 2 CREATE SERVER.

CREATE EXTENSION would fail if I didn't install multicorn at all

master: must succeed: sudo -u postgres psql -c 'CREATE EXTENSION multicorn;'
master # [   23.683311] sudo[816]:     root : TTY=hvc0 ; PWD=/tmp ; USER=postgres ; COMMAND=/run/current-system/sw/bin/psql -c CREATE EXTENSION multicorn;
master # [   23.689987] sudo[816]: pam_unix(sudo:session): session opened for user postgres by (uid=0)
master # [   23.861224] sudo[816]: pam_unix(sudo:session): session closed for user postgres
(0.24 seconds)
master: must succeed: cat /nix/store/prrbpdvqbbfqiw09rn3hazyvv0c4ca0q-postgresql-test | sudo -u postgres psql
master # [   23.897364] sudo[821]:     root : TTY=hvc0 ; PWD=/tmp ; USER=postgres ; COMMAND=/run/current-system/sw/bin/psql
master # [   23.904081] sudo[821]: pam_unix(sudo:session): session opened for user postgres by (uid=0)
master # [   23.976365] postgresql-start[823]: [823] ERROR:  Error in python: ImportError
master # [   23.978526] postgresql-startERROR:  Error in python: ImportError
master # DETAIL:  No module named multicorn
master # [823]: [823] DETAIL:
master # [   23.984437] postgresql-start[823]: [823] STATEMENT:  CREATE SERVER multicorn_imap FOREIGN DATA WRAPPER multicorn options (wrapper 'multicorn.imapfdw.ImapFdw');
master: output:
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbigras
Copy link
Contributor Author

bbigras commented Jun 25, 2020

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 25, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 25, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@bbigras
Copy link
Contributor Author

bbigras commented Jun 25, 2020

/state needs_work

@bbigras bbigras closed this Mar 31, 2021
@bbigras bbigras deleted the multicorn branch March 31, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice will be requested when the pull request is marked ready for review thoughtpolice is a code owner

@marsam marsam Awaiting requested review from marsam marsam will be requested when the pull request is marked ready for review marsam is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbigras @ryantm