ddcui: init at 0.1.1 #91627
Merged
ddcui: init at 0.1.1 #91627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sikmir
reviewed
Jun 26, 2020
| # file is not currently written to support PREFIX installations. | ||
| cmake | ||
| pkg-config | ||
| wrapQtAppsHook |
There was a problem hiding this comment.
You can remove wrapQtAppsHook and qtbase from inputs using proper Qt wrapping, see #65399.
There was a problem hiding this comment.
You can remove wrapQtAppsHook
Great!
You can remove [...] qtbase
That's a bit surprising, given that the manual gives it as the main example:
https://hydra.nixos.org/build/96804884/download/1/nixpkgs/manual.html#sec-language-qt
So is it now recommended to include it, or not?
There was a problem hiding this comment.
Well, I don't know why it is recommended to include in the manual. I just see a lot of packages without explicit qtbase input.
There was a problem hiding this comment.
OK, then I'll stick with including it for now to be as close to the manual as possible.
markuskowa
reviewed
Jun 27, 2020
nh2
added a commit
to nh2/nixpkgs
that referenced
this pull request
Jun 27, 2020
As I learned in the review of NixOS#91627.
10 tasks
markuskowa
approved these changes
Jun 27, 2020
sikmir
approved these changes
Jun 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
GUI for
ddcutil, allows adjusting monitor hardware settings:Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)I tested it running on Ubuntu with
sudo ddcuiafter building on NixOS.FYI @rnhmjoj (maintainer of
ddcutil)