Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broot: install man page #91592

Merged
merged 1 commit into from Jun 27, 2020
Merged

broot: install man page #91592

merged 1 commit into from Jun 27, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

broot has a man page, let's install it!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from magnetophon June 26, 2020 11:37
@danieldk danieldk requested a review from bbigras June 27, 2020 12:44
@danieldk
Copy link
Contributor Author

@bbigras since you did some of the recent updates, I thought you might be a good reviewer for this PR ;).

@Ma27 Ma27 merged commit 7e21bb9 into NixOS:master Jun 27, 2020
@bbigras
Copy link
Contributor

bbigras commented Jun 27, 2020

Oh too late. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnetophon magnetophon Awaiting requested review from magnetophon

@bbigras bbigras Awaiting requested review from bbigras

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @bbigras @Ma27