Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: 19.03.11 -> 19.03.12 #91545

Merged
merged 2 commits into from Jun 27, 2020
Merged

docker: 19.03.11 -> 19.03.12 #91545

merged 2 commits into from Jun 27, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Jun 26, 2020

Motivation for this change

https://github.com/docker/docker-ce/releases/tag/v19.03.12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Frostman
Copy link
Member Author

@GrahamcOfBorg test docker

@Frostman
Copy link
Member Author

@jonringer I've updated the PR. It works fine and passes tests, but I'm new to Nix, so, not sure if it's the desired way of using rec.

nixosTests.docker is passing for the PR.

@Ma27 Ma27 merged commit d651626 into NixOS:master Jun 27, 2020
@Ma27
Copy link
Member

Ma27 commented Jun 27, 2020

Thanks! Ported to stable as 0c486cf, b3d20c3

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Jun 27, 2020
@Frostman Frostman deleted the docker-19.03.12 branch June 27, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants