device: add xiaomi-begonia #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to produce boot images that will not brick some MTK devices, namely xiaomi-begonia.
|
Hmm, I want to check this out better, but it looks like shutdown is broken. It will boot back up. It works fine with CFW TWRP, and the non-CFW engineering ROM, even with the CFW installed. There is also an issue with the battery reporting -1%, but I figure it's "a" battery reporting -1% and other batteries are not, since CFW TWRP reports an appropriate percent. |
samueldr
force-pushed
the
device/xiaomi-begonia
branch
2 times, most recently
from
556d6f8
to
3557d0c
Compare
samueldr
force-pushed
the
device/xiaomi-begonia
branch
from
3557d0c
to
b3563e4
Compare
samueldr
force-pushed
the
device/xiaomi-begonia
branch
from
b3563e4
to
6e00fa0
Compare
|
Now patched the device tree so the LED defaults to ON, as is the tradition. |
|
If #174 had a solution, it would have these caveats listed:
|
samueldr
force-pushed
the
device/xiaomi-begonia
branch
2 times, most recently
from
6191243
to
6e00fa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first Mediatek device for Mobile NixOS.
Its introduction may help other contributors with similar vintage Meditak devices. The only one I have in mind is the Cosmo communicator.
Quick review of the device
This is not a device you should consider acquiring with the intent of running anything else than the default operating system. It was graciously provided to the project by a friend of mine. The device is extremely fussy and will brick itself harshly with no good reason.
It seems that some validation code for something, maybe the anti-rollback for MIUI, triggers if you look at the device wrongly.
If it weren't for a leaked engineering ROM, this device would be a good e-waste material, and nothing more. Even with the engineering firmware, it is still trivial to brick, the only thing it gives us is a way to unbrick.
Bricks are real enough bricks. Without the engineering firmware, the bricks require an authorized Mi account to fix, which you are unlikely to have (statistically speaking). It's not something trivial like a bootloop where you could go to fastboot to fix. They are real bricks.
I rate this device -1/10, do not buy.
Other things of note