Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zenpower: 0.1.10 -> 0.1.12 #91574

Closed
wants to merge 1 commit into from
Closed

zenpower: 0.1.10 -> 0.1.12 #91574

wants to merge 1 commit into from

Conversation

voanhduy1512
Copy link
Contributor

Motivation for this change

New version adds support kernel 5.7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@voanhduy1512
zenpower: 0.1.10 -> 0.1.12
b8aad23 
New version adds support kernel 5.7
@ofborg ofborg bot requested a review from alexbakker June 26, 2020 09:18
alexbakker
alexbakker approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danieldk
Copy link
Contributor

danieldk commented Jul 3, 2020

Thanks for this PR! Turns out that there was already an older PR with the same change: #90519, so closing this.

@danieldk danieldk closed this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbakker alexbakker alexbakker approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@voanhduy1512 @danieldk @alexbakker