Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

olive-editor: use wrapQtAppsHook #89345

Merged
merged 1 commit into from Jun 4, 2020
Merged

olive-editor: use wrapQtAppsHook #89345

merged 1 commit into from Jun 4, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 2, 2020 •
edited by ghost

Tracking Issue: #65399

Motivation for this change

Olive editor complains about missing qt package and will not start (Wayland/SwayWM)

2020-06-03T08:05:18 [WARNING] Could not find the Qt platform plugin "xcb" in ""
2020-06-03T08:05:18 [FATAL] This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

[1]    5089 abort (core dumped)  olive-editor
Things done

Added wrapQtAppsHook at the top of file and in mkDerivation

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from balsoft June 2, 2020 06:35
@drewrisinger
Copy link
Contributor

Fails to launch on Ubuntu 18.04. Had similar troubles with other GTK apps on Ubuntu before, so take with a grain of salt.

[nix-shell:~/.cache/nixpkgs-review/pr-89345]$ olive-editor

(process:980): Gtk-WARNING **: 09:45:56.615: Locale not supported by C library.
        Using the fallback 'C' locale.
Gtk-Message: 09:45:56.812: Failed to load module "canberra-gtk-module"
Gtk-Message: 09:45:56.812: Failed to load module "canberra-gtk-module"
2020-06-02T09:45:56 [WARNING] qglx_findConfig: Failed to finding matching FBConfig for QSurfaceFormat(version 2.0, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize 0, redBufferSize 1, greenBufferSize 1, blueBufferSize 1, alphaBufferSize -1, stencilBufferSize -1, samples -1, swapBehavior QSurfaceFormat::SingleBuffer, swapInterval 1, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::NoProfile)
2020-06-02T09:45:56 [WARNING] qglx_findConfig: Failed to finding matching FBConfig for QSurfaceFormat(version 2.0, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize 0, redBufferSize 1, greenBufferSize 1, blueBufferSize 1, alphaBufferSize -1, stencilBufferSize -1, samples -1, swapBehavior QSurfaceFormat::SingleBuffer, swapInterval 1, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::NoProfile)
2020-06-02T09:45:56 [FATAL] Could not initialize GLX
Aborted (core dumped)

@ghost
Copy link
Author

ghost commented Jun 2, 2020

Related to #85866?

@ghost
Copy link
Author

ghost commented Jun 2, 2020 •
edited by ghost

Also #66755 #82959 #85921
@drewrisinger Does olive-editor run before this commit?

drewrisinger
drewrisinger approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM.
  • Builds fine.
  • Running fails on my machine due to issues with Nix + Ubuntu graphics, but contributor said works locally.

@bhipple
Copy link
Contributor

bhipple commented Jun 4, 2020

Result of nixpkgs-review pr 89345 1

1 package built:
- olive-editor

@bhipple bhipple merged commit 1ae28eb into NixOS:master Jun 4, 2020
@bhipple
Copy link
Contributor

bhipple commented Jun 4, 2020

Works just fine for me now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balsoft balsoft Awaiting requested review from balsoft

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @bhipple