Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: 19.03.10 -> 19.03.11 #89314

Merged
merged 1 commit into from Jun 1, 2020
Merged

docker: 19.03.10 -> 19.03.11 #89314

merged 1 commit into from Jun 1, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Jun 1, 2020 •
edited

Motivation for this change

https://github.com/docker/docker-ce/releases/tag/v19.03.11

Things done

nixosTests.docker passed

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Ma27 Ma27 merged commit 1ea4564 into NixOS:master Jun 1, 2020
@Ma27
Copy link
Member

Ma27 commented Jun 1, 2020

@Frostman should we also backport this?

@Frostman Frostman deleted the docker-19.03.11 branch June 1, 2020 16:49
@Frostman
Copy link
Member Author

Frostman commented Jun 1, 2020

@Ma27 yes, I think so, I'll prep and test it later today.

@Frostman
Copy link
Member Author

Frostman commented Jun 2, 2020

@Ma27 I've prepared backport for 20.03 #89336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@vdemeester vdemeester Awaiting requested review from vdemeester

@periklis periklis Awaiting requested review from periklis

@tailhook tailhook Awaiting requested review from tailhook

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Frostman @Ma27