Fixed Animation::HasPendingActivity for scroll-linked animations #23892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 1, 2020
Finished scroll animations should be reported as having pending activity so they are not collected by GC. Modified Animation::HasPendingActivity to return true if it's a scroll animation and the timeline has a scroller. Bug: 1079296 Change-Id: I77776c1681c4ff625d07767cdb9b245e0be0e70e
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2223998
branch
from
ff47aa8
to
8a7b2bb
Compare
|
Close this PR because the Chromium CL cannot be found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished scroll animations should be reported as having pending activity
so they are not collected by GC.
Modified Animation::HasPendingActivity to return true if it's a scroll
animation and the timeline has a scroller.
Bug: 1079296
Change-Id: I77776c1681c4ff625d07767cdb9b245e0be0e70e
Reviewed-on: https://chromium-review.googlesource.com/2223998
WPT-Export-Revision: fe0b755b7fc06d4bd2170844f96a709a3c9128a0