tensorflow-haskell: Remove tensorflow-mnist #89347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its tensorflow-mnist-data dependency is not on Hackage, and the license conditions for the data are unclear. Also, it's basically an example package.
|
@mikesperber LGTM, thanks for following up here! |
|
@cdepillabout Thank YOU for your patience and support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
tensorflow-mnist was marked broken as its dependency, tensorflow-mnist-input-data, was not on Hackage. That in turn was because the license conditions are unclear.
See also this discussion here:
#88604
Also here over on tensorflow-haskell:
tensorflow/haskell#260
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)