[ScrollTimeline] Fix null-deref READ when resolved scroll source is null #23894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 1, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2223995
branch
from
e6a9cf5
to
2eaef1d
Compare
The resolved scroll source of ScrollTimeline could be null so we should check before dereference it when checking whether it uses composited scrolling. Bug: 1088319 Change-Id: Ib20cceefcd0e1de05cf1d5932a6da6aac37ef8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223995 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#773847}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2223995
branch
from
2eaef1d
to
82feada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolved scroll source of ScrollTimeline could be null so we should
check before dereference it when checking whether it uses composited
scrolling.
Bug: 1088319
Change-Id: Ib20cceefcd0e1de05cf1d5932a6da6aac37ef8b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223995
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773847}