Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Remove intrinsic overrides in LayoutImage, etc. #23899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

Initially added in:
https://chromium-review.googlesource.com/c/chromium/src/+/1150725/
https://chromium-review.googlesource.com/c/chromium/src/+/1191926/
https://chromium-review.googlesource.com/c/chromium/src/+/1210544/

This now appears to be (somewhat) dead code. Previous patches removed
the intrinsicSize attribute which this was initially hooked up to.

This code actually slightly dangerous at the moment, as it appears that
if you have certain feature policies turned on you will get subtly
different behaviour that what you expected.

E.g. the "document-write" policy?
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/feature_policy/feature_policy_features.json5;l=132?q=experimentalproductivityfeatures%20file:json5&ss=chromium%2Fchromium%2Fsrc&originalUrl=https:%2F%2Fcs.chromium.org%2F

This leaves the reporting behaviour in:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/layout_image.cc;l=437?q=isdefaultintrinsicsize&ss=chromium&originalUrl=https:%2F%2Fcs.chromium.org%2F

Change-Id: I80d1d376753070dc94559e3177d31c0fd3439700

Reviewed-on: https://chromium-review.googlesource.com/2224992
WPT-Export-Revision: e8af1c3e8457b31ee5a8b899310cdfa51e07ac50

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants