make-disk-image: add hybrid and dynamic sized images #89331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lassulus
changed the title
Lassulus
changed the title
Lassulus
requested review from
alyssais and
dezgeg
and removed request for
alyssais
|
This now also incorporates a fix to run |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
I don't really understand stuff in this nix file, so I just pushed an improved version of the easy fix as 8d05772. |
Lassulus
force-pushed
the
make-disk-image
branch
from
2534c63
to
8a92517
Compare
|
after some testing I realized, that this fails sometimes when building efi/hybrid images. will have to debug and fix that. |
Lassulus
changed the title
Lassulus
force-pushed
the
make-disk-image
branch
from
8a92517
to
78410dc
Compare
Lassulus
force-pushed
the
make-disk-image
branch
from
78410dc
to
883a607
Compare
Lassulus
changed the title
|
tested all partitionTableTypes with my x220 and all of them booted. So this seems good to go. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was bitten by the fixed diskSize a couple of times.
Also there was no way to increase the boot partition size, which also made some problems with unfree firmware.
I also added hybrid images, which could be booted via efi or mbr, if used with grub.
Will still have to test around and see if any problems arise. Also I would prefer to use sgdisk over parted since I prefer the script interface. But there are problems with msdos partiton tables, so I implemented it with parted.