Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hlint: fix evaluation problems #89349

Merged
merged 1 commit into from Jun 2, 2020
Merged

haskellPackages.hlint: fix evaluation problems #89349

merged 1 commit into from Jun 2, 2020

Conversation

cdepillabout
Copy link
Member

Motivation for this change

haskell-packages was failing to evaluate. This was because of some finicky overrides for the new hlint.

I've added some packages to our extra-packages so that this problem doesn't happy again in the near future.

I've checked that haskell-updates can now safely evaluate with the nix-env -qa --out-path -f. command.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [X ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout cdepillabout requested a review from peti June 2, 2020 08:39
@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.hlint

@peti
Copy link
Member

peti commented Jun 2, 2020

I've added some packages to our extra-packages so that this problem doesn't happen again in the near future.

Personally, I prefer the evaluation error over carrying around obsolete extra-packages.

@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.hlint

@peti No problem. I rebased the PR to take out the changes to extra-packages.

I had thought that you would prefer to have stuff like this in extra-packages so that it makes the weekly updates/merges you do easier (for packages that have frequent releases).

@peti
Copy link
Member

peti commented Jun 2, 2020

I had thought that you would prefer to have stuff like this in extra-packages so that it makes the weekly updates/merges you do easier (for packages that have frequent releases).

Yes, for some packages that would be the case. For packages that I personally like and frequently use, however, it's more important to me to have them built with the respective latest versions of their dependencies so that I don't run into bugs or other issues that these updates fixed.

@peti peti merged commit 70ec727 into NixOS:haskell-updates Jun 2, 2020
@cdepillabout cdepillabout deleted the get-haskell-packages-evaling branch June 2, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdepillabout @peti