python3Packages.cookiecutter: add missing slugify dependency #89340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kragniz
approved these changes
Jun 2, 2020
jonringer
reviewed
Jun 3, 2020
There was a problem hiding this comment.
To comply with CONTRIBUTING.md please have the commit message name be of the format
<pkg-name>: <subject-line>
for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes
in your case, the commit message should be:
python3Packages.cookiecutter: add missing slugify dependency
otherwise LGTM
|
Thanks @jonringer , I updated the commit message, and will make sure that my future PR's follows |
|
@kragniz This also works for MacOS. |
bhipple
changed the title
|
Result of 6 packages built:- aws-sam-cli - cookiecutter (python37Packages.cookiecutter) - python27Packages.cookiecutter - python37Packages.mesa - python38Packages.cookiecutter - python38Packages.mesa |
bhipple
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
cookiecutter currently (
cfa5a0c0e09) does not build, complaining that it can not find python-slugify dependency. This PR adds the dependency to fix the build.It was working at least until last week, but I do not know what broke it. Probably a transitive dependency used to depend on python-slugify.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)