Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hydra-unstable: 2020-04-16 -> 2020-06-01 #89297

Merged
merged 1 commit into from Jun 9, 2020
Merged

hydra-unstable: 2020-04-16 -> 2020-06-01 #89297

merged 1 commit into from Jun 9, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 1, 2020 •
edited

Motivation for this change

Update Hydra to latest master.

Should we also backport this? Needs backport for #89305.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wizeman wizeman mentioned this pull request Jun 1, 2020
Closed
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jun 1, 2020
andir
andir approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests did execute locally but I haven't actually tried to upgrade a hydra instance to this PR.

@Ma27
Copy link
Member Author

Ma27 commented Jun 2, 2020

Fixed hydra-send-stats in NixOS/hydra#773, migration went well.

@Ma27 Ma27 requested a review from andir June 2, 2020 13:46
@ajs124 ajs124 mentioned this pull request Jun 8, 2020
Closed
10 tasks
ajs124 referenced this pull request Jun 8, 2020
@edolstra
nixFlakes: 2.4pre20200501_941f952 -> 2.4pre20200521_00b562c
fdecd9e
@edolstra edolstra merged commit 51e8a82 into NixOS:master Jun 9, 2020
@Ma27 Ma27 deleted the bump-hydra branch June 9, 2020 11:18
@Ma27
Copy link
Member Author

Ma27 commented Jun 9, 2020

Currently working on backporting this.

@Ma27
Copy link
Member Author

Ma27 commented Jun 9, 2020

Backported as 92d5b1b

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

@edolstra edolstra Awaiting requested review from edolstra

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
6.topic: nixos 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @andir @edolstra