New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify code by removing 2 global variables. #8178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of the timer could be a third commit, if you want.
Thanks. It's indeed cleaner this way. |
src/industry_gui.cpp
Outdated
@@ -447,10 +448,14 @@ class BuildIndustryWindow : public Window { | |||
strdim.width = max_minwidth; | |||
} | |||
d = maxdim(d, strdim); | |||
|
|||
if (indsp->grf_prop.grffile != nullptr) { | |||
extra_lines_newgrf = max(extra_lines_newgrf, 4); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this just be
extra_lines_newgrf = max(extra_lines_newgrf, 4); | |
extra_lines_newgrf = 4; |
? It's not modified anywhere else (also preferrably with some comment/constant name ? )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, and added a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.