Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/testing: Add support for specialArgs #89361

Merged
merged 1 commit into from Sep 16, 2020
Merged

nixos/testing: Add support for specialArgs #89361

merged 1 commit into from Sep 16, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jun 2, 2020 •
edited

Since using flakes disallows the usage of <unstable> (which I use in
some tests), this adds an alternative. By setting specialArgs, all VMs
can get the unstable flake input as an arg. This is not possible with
extraConfigurations, as that would lead to infinite recursions.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ dasJ requested review from flokli and infinisil August 21, 2020 16:58
@dasJ
nixos/testing: Add support for specialArgs
9f33ab6 
Since using flakes disallows the usage of <unstable> (which I use in
some tests), this adds an alternative. By setting specialArgs, all VMs
can get the `unstable` flake input as an arg. This is not possible with
extraConfigurations, as that would lead to infinite recursions.
@dasJ dasJ requested a review from tfc September 13, 2020 22:11
@tfc tfc merged commit 713f881 into NixOS:master Sep 16, 2020
@dasJ dasJ deleted the feat/test-special-args branch September 19, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc approved these changes

@ajs124 ajs124 ajs124 approved these changes

@flokli flokli Awaiting requested review from flokli

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasJ @tfc @ajs124