New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openresty: disable perl module by default #89344
Conversation
Hmm, if it was about |
@7c6f434c sure, will do if you want. |
fcace23
to
4140ffb
Compare
@7c6f434c done. |
I think even this version should still mention switching to the |
4140ffb
to
d606ad0
Compare
@7c6f434c done |
d606ad0
to
018496c
Compare
Apparently I fail to express what I am actually annoyed by. You replace (In principle, |
@7c6f434c I'm still confused sorry. The motivation for all of this, like I explained in the PR, is that I can't check for |
That means that in the status quo it is impossible for a user to turn off perl in openresty (except by overriding to delete some configure flags) |
018496c
to
4cdbf23
Compare
I still don't understand what you want at this point. Is the issue that the commit message is not explicit that the change affects all nginx packages? |
Yes — as I said, I agree with the changes themselves. |
Previously, http_perl_module was disabled by overriding perl=null -- this means it is impossible to disable http_perl_module in openresty, since openresty requires perl for its configure scripts.
I have been experiencing intermittent segfaults inside the perl module on startup during config parsing, despite not actually using any perl features in my config. This creates consistency with the standard nginx packages, and the upstream openresty binaries.
4cdbf23
to
22906fc
Compare
@7c6f434c I split this into two commits that are more clear about what they apply to -- hope that seems right to you. |
Thanks! |
Motivation for this change
This creates consistency with the other nginx packages.
Additionally, I have been receiving intermittent segfaults during config loading caused by the perl module (albeit on 20.03), despite there being no reference to perl in my configs:
The change from specifying
perl = null
towithPerl
is necessary due to openresty's use of perl in its configure script.I have tested
nginxStable
,nginxUnstable
,nginxShibboleth
, andopenresty
using my unmerged nginx-variant tests from #89342.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)