Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeself: add which to nativeBuildInputs #89343

Closed
wants to merge 1 commit into from

Conversation

Emantor
Copy link
Member

@Emantor Emantor commented Jun 2, 2020

Motivation for this change

The latest release requires which for the test runs, add it to
nativeBuildInputs to let the tests succeed.

This should fix https://hydra.nixos.org/build/121138562

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The latest release requires which for the test runs, add it to
nativeBuildInputs to let the tests succeed.
@flokli
Copy link
Contributor

flokli commented Jun 2, 2020

If this is something only required for tests, it should be part of checkInputs.

But: this seems to build for me on current master, even without this PR.
It complains about which not available, but the tests still succeed.

I assume that failure on Hydra was caused by something else - further up in the logs, there's the following:

Not enough space left in /build (2600707200 KB) to decompress ./makeself-test.run (1 KB)
Use --nodiskspace option to skip this check and proceed anyway
Consider setting TMPDIR to a directory with more free space.
testQuiet:20:Failed

This seems to be a faulty comparison? 2600707200 clearly is greater than 1…

Digging further, there's also the following:

tail: invalid number of lines: '+'

gzip: stdin: unexpected end of file

I wonder if more is crashing here, but the test suite doesn't properly exit…

@jtojnar
Copy link
Contributor

jtojnar commented Jun 3, 2020

I agree that it should be part of checkInputs since it is only optionally required by extracttest:

https://github.com/megastep/makeself/search?q=which&unscoped_q=which

but since it is || returned there

https://github.com/megastep/makeself/blob/6a9d0e4e3598c897f7571ed5e5e6ca798727316f/test/extracttest#L42

it cannot cause the failure.

Maybe something to do with megastep/makeself#212

@jtojnar
Copy link
Contributor

jtojnar commented Jun 3, 2020

Weird. The comparison looks fine to me and has not been changed recently:

https://github.com/megastep/makeself/blame/1c2f8eb47e3bb1d895a3c7278319632fac6170bd/makeself-header.sh#L599

@vcunat vcunat closed this in 753a237 Aug 15, 2020
@vcunat
Copy link
Member

vcunat commented Aug 15, 2020

Adding which made it succeed at the first attempt, so I hope it wasn't just luck.

wchresta pushed a commit to wchresta/nixpkgs that referenced this pull request Aug 17, 2020
I've been unable to reproduce the problem that repeatedly manifests
on Hydra, but this change is cheap.  Close NixOS#89343 (thanks).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants