Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the mathematica::Logger everywhere to output Mathematica traces #2599

Merged
merged 15 commits into from
Jun 1, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jun 1, 2020

  1. Add a function Logger::Set for single values, which we sometimes have to log.
  2. Add a notebook to perform regression testing of the logger.

The test notebook verifies that the old (2017-2019) files and the new ones are identical. It finds two differences: in one case (KSP system convergence) the numerical values changed, but the structure of the file is identical; in another case (solar system convergence) the old file was mysteriously empty.

This looks like it adds a lot of code because of the notebook.

@eggrobin eggrobin added the LGTM label Jun 1, 2020
@pleroy pleroy merged commit 639ce0a into mockingbirdnest:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants