Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coz: fix python shebang #89306

Merged
merged 1 commit into from Jun 4, 2020
Merged

Conversation

minijackson
Copy link
Member

Motivation for this change

Currently, the coz package installs the coz script directly, which uses the environment's Python. This should make the closure depend on Python 3 and fixes the shebang.

Note: while the script uses Python2.7, the README says that Python 3 is recommended, and I've tested the script with Python 3 a bit, and seems to run just fine.

This also removes the unset of PYTHONPATH, which is not done by wrapPythonPrograms, so I'm paging @zimbatm to ask if he still has the same issue with this method.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not using it right now. If it works for you then it's good to merge.

@bhipple
Copy link
Contributor

bhipple commented Jun 4, 2020

Result of nixpkgs-review pr 89306 1

1 package built:
- coz

@bhipple bhipple merged commit 9fc6768 into NixOS:master Jun 4, 2020
@minijackson minijackson deleted the coz-fix-python-shebang branch June 4, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants