Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firmwareLinuxNonfree: 2020-01-22 -> 2020-05-19 #89307

Merged
merged 1 commit into from Jun 1, 2020
Merged

firmwareLinuxNonfree: 2020-01-22 -> 2020-05-19 #89307

merged 1 commit into from Jun 1, 2020

Conversation

jsravn
Copy link
Contributor

@jsravn jsravn commented Jun 1, 2020 •
edited

Motivation for this change

Contains navi14 firmware that is part of the amdgpu 20.10 release (https://www.amd.com/en/support/kb/release-notes/rn-amdgpu-unified-linux-20-10). This is needed for the latest 5.6 kernel to support 5500XT/5600XT/5700XT. This firmware isn't currently in 2020-01-22, so when I use linuxPackages_latest on 20.03 I get the error psp v11.0: Failed to load firmware "amdgpu/navi14_ta.bin".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fpletz June 1, 2020 13:28
@jsravn
Copy link
Contributor Author

jsravn commented Jun 1, 2020

I guess this change needs to be backported to 20.03 as well to support 5.6?

@Mic92 Mic92 merged commit 3cb2979 into NixOS:master Jun 1, 2020
@Mic92
Copy link
Member

Mic92 commented Jun 1, 2020

Yes. Please open a pull request for that.

@jsravn jsravn mentioned this pull request Jun 1, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsravn @Mic92 @Janik-Haag