Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smartmontools-db: 4883 -> 5033 #89335

Merged
merged 1 commit into from Jun 2, 2020
Merged

smartmontools-db: 4883 -> 5033 #89335

merged 1 commit into from Jun 2, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Jun 1, 2020 •
edited

Motivation for this change

There are a lot of new devices added to the Smartmontools DB. Last time we've updated it was about three months ago in #81099.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of running nixpkgs-review (none seems to be related to smartmontools):

2 package marked as broken and skipped:
docker-machine-xhyve tlspool

8 package failed to build:
gnome3.gnome-boxes libguestfs libguestfs-with-appliance libvmi python27Packages.guestfs python37Packages.guestfs python38Packages.
guestfs vagrant

73 package built:
ceph ceph-client collectd collectd-data deepin.dde-api deepin.dde-control-center deepin.dde-daemon deepin.dde-dock deepin.dde-file
-manager deepin.dde-kwin deepin.dde-launcher deepin.dde-session-ui deepin.deepin-desktop-base deepin.deepin-desktop-schemas deepin
.deepin-wallpapers deepin.startdde docker-machine-kvm docker-machine-kvm2 easysnap grub2 grub2_efi grub2_pvgrub_image grub2_xen gs
martcontrol libceph libvirt libvirt-glib libvirt_5_9_0 linuxPackages-libre.zfs linuxPackages.zfs linuxPackages_4_14.zfs linuxPacka
ges_4_19.zfs linuxPackages_4_4.zfs linuxPackages_4_9.zfs linuxPackages_5_6.zfs linuxPackages_hardened.zfs linuxPackages_latest-lib
re.zfs linuxPackages_latest_hardened.zfs linuxPackages_latest_xen_dom0.zfs linuxPackages_latest_xen_dom0_hardened.zfs linuxPackage
s_testing_bcachefs.zfs linuxPackages_xen_dom0.zfs linuxPackages_xen_dom0_hardened.zfs minikube minishift nixops nixopsUnstable nix
ops_1_6_1 ocamlPackages.ocaml_libvirt os-prober perl528Packages.SysVirt perl530Packages.SysVirt python27Packages.libvirt python37P
ackages.libvirt python38Packages.libvirt rubyPackages.ruby-libvirt rubyPackages_2_5.ruby-libvirt rubyPackages_2_7.ruby-libvirt sam
ba4Full sanoid smartmontools terraform-full terraform-provider-libvirt terraform_0_11-full terragrunt tlp virtmanager virtmanager-
qt virt-top virtviewer virtlyst zfs zfstools

This change is Reviewable

@ofborg ofborg bot requested a review from peti June 2, 2020 00:03
@peti peti merged commit 5eb6f54 into NixOS:master Jun 2, 2020
@Frostman Frostman deleted the smartmontools-db-update branch June 2, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Frostman @peti