Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] docker: 19.03.5 -> 19.03.11 #89336

Merged
merged 5 commits into from Jun 2, 2020
Merged

[20.03] docker: 19.03.5 -> 19.03.11 #89336

merged 5 commits into from Jun 2, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Jun 2, 2020 •
edited

Motivation for this change

Backport docker version updates and 2 useful commits that adds git to extraPath and switches to installShellCompletion.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

Milan Pässler and others added 5 commits June 1, 2020 17:10
@Frostman
docker: add git to extraPath
7bf0d1c 
When building a docker container from git, docker was missing the git
binary in $PATH.

(cherry picked from commit 08d83c1)
@zowoq @Frostman
docker: use installShellFiles
52cc587 
(cherry picked from commit 764dd5c)
@Frostman
docker: 19.03.8 -> 19.03.9
1e1b0ac 
(cherry picked from commit fb3039d)
@Frostman
docker: 19.03.9 -> 19.03.10
33973b7 
(cherry picked from commit c8dddcb)
@Frostman
docker: 19.03.10 -> 19.03.11
4aad3f5 
(cherry picked from commit a4ea8ab)
@Frostman Frostman mentioned this pull request Jun 2, 2020
Merged
10 tasks
@Frostman Frostman requested a review from Ma27 June 2, 2020 00:12
@Ma27 Ma27 merged commit 20fcae3 into NixOS:release-20.03 Jun 2, 2020
@Frostman Frostman deleted the docker-backport-19.03.11 branch June 2, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@vdemeester vdemeester Awaiting requested review from vdemeester

@tailhook tailhook Awaiting requested review from tailhook

@periklis periklis Awaiting requested review from periklis

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @Ma27 @zowoq