Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel-buildtools: 2.2.1 -> 3.2.0 #89357

Merged
merged 1 commit into from Jun 4, 2020
Merged

bazel-buildtools: 2.2.1 -> 3.2.0 #89357

merged 1 commit into from Jun 4, 2020

Conversation

avdv
Copy link
Member

@avdv avdv commented Jun 2, 2020 •
edited

Motivation for this change

Version 3.0.0 released on April, 28th.
Version 3.2.0 released on Juli, 2nd.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@avdv avdv requested a review from Profpatsch as a code owner June 2, 2020 12:37
@ofborg ofborg bot requested review from elasticdog, marsam and uri-canva June 2, 2020 12:45
uri-canva
uri-canva approved these changes Jun 3, 2020
View reviewed changes
pkgs/development/tools/build-managers/bazel/buildtools/default.nix

goPackagePath = "github.com/bazelbuild/buildtools";

src = fetchFromGitHub {
owner = "bazelbuild";
repo = "buildtools";
rev = version;
sha256 = "165jvn7r7bxivb8mpvp6dni5a5ns9a3vm6y5clyxdbjhfkll8wra";
sha256 = "1zv3nagam2x1w072yiv7314183z0saabhj9g7yvlfs8ld1m01xss";
};

goDeps = ./deps.nix;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell in the repo the deps didn't change, but I don't remember how this file was generated in the first place. Especially the protobuf dependency come from a transitive dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably has been generated by go2nix initially?

BTW, version 3.2.0 has been released a few hours ago. I'll update this PR.

@avdv avdv changed the title bazel-buildtools: 2.2.1 -> 3.0.0 bazel-buildtools: 2.2.1 -> 3.2.0 Jun 4, 2020
@ofborg ofborg bot requested a review from uri-canva June 4, 2020 06:43
@marsam marsam merged commit a1cae93 into NixOS:master Jun 4, 2020
@avdv avdv deleted the bazel-buildtools-3 branch June 4, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-canva uri-canva uri-canva approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@elasticdog elasticdog Awaiting requested review from elasticdog

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avdv @uri-canva @marsam