Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple jobsets per Flake #772

Closed
wants to merge 1 commit into from

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jun 2, 2020

This allows usage of #, just as nix run does. This way, multiple
jobsets can be configured per flake.nix. For the path given after #,
an attribute is looked up and either hydraJobs or checks is searched
there.

For example nixpkgs#example will try to evaluate example.hydraJobs
in nixpkgs.

This allows usage of `#`, just as `nix run` does. This way, multiple
jobsets can be configured per flake.nix. For the path given after `#`,
an attribute is looked up and either `hydraJobs` or `checks` is searched
there.

For example `nixpkgs#example` will try to evaluate `example.hydraJobs`
in nixpkgs.
@edolstra
Copy link
Member

edolstra commented Jun 2, 2020

The problem is that nix flake check doesn't know about these attributes. Maybe we can have an attribute hydraJobsets, and require that you can only specify #hydraJobsets.<jobsetname> or #checks.

auto releaseExpr = myArgs.releaseExpr;

// Handle attribute selectors
auto hash = releaseExpr.find('#');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done using parseFlakeRefWithFragment.

@dasJ dasJ closed this Sep 13, 2020
@dasJ dasJ deleted the flake-multi-jobsets branch September 13, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants