Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwupd: fix configuration on aarch64 #89356

Merged
merged 1 commit into from Jun 5, 2020
Merged

fwupd: fix configuration on aarch64 #89356

merged 1 commit into from Jun 5, 2020

Conversation

wizeman
Copy link
Member

@wizeman wizeman commented Jun 2, 2020

Motivation for this change

The fwupd service was failing on aarch64 with:

fwupd: Failed to load engine: Failed to load remotes: failed to load /etc/fwupd/remotes.d/dell-esrt.conf: No such file or directory

The /etc/fwupd/remotes.d/dell-esrt.conf symlink existed but it pointed to a non-existent file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wizeman
fwupd: fix configuration on aarch64
ec4d914 
The fwupd service was failing on aarch64 with:

fwupd: Failed to load engine: Failed to load remotes: failed to load /etc/fwupd/remotes.d/dell-esrt.conf: No such file or directory

The /etc/fwupd/remotes.d/dell-esrt.conf symlink existed but it pointed to a non-existent file.
@matthewbauer
Copy link
Member

I wonder why this only happens on aarch64?

@wizeman
Copy link
Member Author

wizeman commented Jun 2, 2020

That's because on aarch64 haveDell gets evaluated to false and therefore the dell plugin doesn't get built and the /nix/store/fwupd-.../etc/fwupd/remotes.d/dell-esrt.conf file doesn't get installed, so we end up with a symlink in /etc pointing to a non-existent /nix/store/fwupd-.../etc/.../dell-esrt.conf file.

The failure to open the symlink causes the fwupd service to fail to start.

@wizeman
Copy link
Member Author

wizeman commented Jun 2, 2020

cc @worldofpeace @dtzWill @jtojnar

@matthewbauer matthewbauer merged commit fa29c10 into NixOS:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wizeman @matthewbauer