Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: 0.4.2 -> 0.4.3 #89321

Closed
wants to merge 1 commit into from
Closed

alacritty: 0.4.2 -> 0.4.3 #89321

wants to merge 1 commit into from

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Jun 1, 2020 •
edited

alacritty/alacritty@v0.4.2...v0.4.3

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Something interesting is that apparently 0.4.3 was already present on the cache? No clue how that happened, but --checking it showed it was different...

@cole-h
Copy link
Member Author

cole-h commented Jun 1, 2020

Already done in 043ecdb.

@cole-h cole-h closed this Jun 1, 2020
@cole-h cole-h deleted the alacritty branch June 1, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cole-h