Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qv2ray: Init at 2.6.3 #89322

Merged
merged 2 commits into from
Nov 29, 2020
Merged

qv2ray: Init at 2.6.3 #89322

merged 2 commits into from
Nov 29, 2020
+80 −0

Conversation

poscat0x04
Copy link
Contributor

Motivation for this change

qv2ray is a GUI frontend to the network proxying tool v2ray.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 1, 2020
@poscat0x04
Copy link
Contributor Author

Thank you for your generous help! I'm terribly sorry that I forgot to read the nixpkgs manual before opening this PR and I'll try to be less careless next time.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jun 1, 2020
symphorien
symphorien approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiles fine with nix-review and a window shows up when launched.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/213

jonringer
jonringer reviewed Jul 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use qt5's mkDerivation, it will automatically wrap the programs for you

@poscat0x04 poscat0x04 force-pushed the add-qv2ray branch 2 times, most recently from 7a47456 to f9b29ab Compare November 23, 2020 07:19
@poscat0x04 poscat0x04 changed the title qv2ray: Init at 2.5.0 qv2ray: Init at 2.6.3 Nov 23, 2020
maintainers: add poscat

Verified

This commit was signed with the committer’s verified signature.
renovate-bot Mend Renovate
GPG key ID: 81C63AE1C224182B
Verified
Learn about vigilant mode
ca03063
@poscat0x04
Copy link
Contributor Author

ping @jonringer

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/390

@marsam marsam merged commit 84a942c into NixOS:master Nov 29, 2020
@poscat0x04 poscat0x04 deleted the add-qv2ray branch November 29, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@IvarWithoutBones IvarWithoutBones

@marsam marsam

@symphorien symphorien

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@poscat0x04 @nixos-discourse @marsam @jonringer @symphorien @IvarWithoutBones