Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exult: 1.4.9rc1 -> 1.6 #89364

Merged
merged 1 commit into from
Aug 28, 2020
Merged

exult: 1.4.9rc1 -> 1.6 #89364

merged 1 commit into from
Aug 28, 2020
+4 −134

Conversation

patrl
Copy link
Contributor

@patrl patrl commented Jun 2, 2020 •
edited
Loading

Motivation for this change

Update exult to verion 1.6.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Some notes:

  • As far as I can see, the patch is now unnecessary, so I've removed it.
  • exult is now built against SDL2.
  • I've removed makeFlags, since it was resulting in a nested dir structure in the nix store.

pinging: @edolstra

Sorry, something went wrong.

@ofborg ofborg bot requested a review from edolstra June 2, 2020 15:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 2, 2020
@patrl patrl changed the title Update exult to 1.6 exult: 1.4.9rc1 -> 1.6 Jun 2, 2020
@patrl
Copy link
Contributor Author

patrl commented Jun 26, 2020

This should be a pretty straightforward PR. Is there anything I can do to get this moving?

@Lassulus
Copy link
Member

hey, can you squash your one commit which says: exult: 1.4.9rc1 -> 1.6
also sorry for the long delay. I guess it fell between the cracks somehow

@patrl
Copy link
Contributor Author

patrl commented Aug 27, 2020

No worries! Commits squashed!!

Lassulus
Lassulus reviewed Aug 27, 2020
View reviewed changes
pkgs/games/exult/default.nix Outdated

src = fetchurl {
url = "mirror://sourceforge/exult/${name}.tar.gz";
sha256 = "0a03a2l3ji6h48n106d4w55l8v6lni1axniafnvvv5c5n3nz5bgd";
sha256 = "1dm27qkxj30567zb70q4acddsizn0xyi3z87hg7lysxdkyv49s3s";
# date = 2020-06-02T10:50:06-0400;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why post the date here?

Copy link
Contributor Author

@patrl patrl Aug 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an artifact of John Wiegley's nix-update.el script. I can remove it if necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, IC. Not sure the next person will bump the timestamp if it's not you, so removing would be better IMHO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@patrl
Update to 1.6
c8ef002 
remove patch

Use variable

removed date signature
@Lassulus Lassulus merged commit ee80c91 into NixOS:master Aug 28, 2020
@mausch mausch mentioned this pull request Sep 5, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus

@edolstra edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrl @Lassulus