Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-prefetch-github: 2.3.2 -> 2.4 #89362

Merged
merged 1 commit into from Jun 10, 2020
Merged

nix-prefetch-github: 2.3.2 -> 2.4 #89362

merged 1 commit into from Jun 10, 2020

Conversation

seppeljordan
Copy link
Contributor

Motivation for this change

A new version of nix-prefetch-github was released upstream. A bug was fixed and a feature added.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ma27
Ma27 requested changes Jun 2, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After getting this merged, should I also backport this to stable?

pkgs/development/python-modules/nix-prefetch-github/default.nix Show resolved Hide resolved
@seppeljordan
Copy link
Contributor Author

Hi, unfortunately I have no idea how I should convert this "sri" hash to the old style of hash.

@Ma27
Copy link
Member

Ma27 commented Jun 3, 2020

If you have a recent version of Nix, nix to-base32 sha256-PVB/cL0NVB5pHxRMjg8TLatvIvHjfCvaRWBanVHYT+E= should to the job.

@seppeljordan
Copy link
Contributor Author

@Ma27 Thanks.

@Ma27
Copy link
Member

Ma27 commented Jun 10, 2020

We can merge this now. In 8f9e4be, the minimal Nix-version to evaluate has been bumped to 2.2 which supports SRI (just confirmed that by building this PR locally with Nix 2.2.2 from release-19.03).

@seppeljordan Please note that this is not the case on release-20.03, so if you want to backport patches like this you have to modify the hash using nix to-base32.

@Ma27 Ma27 merged commit a6941d2 into NixOS:master Jun 10, 2020
@seppeljordan seppeljordan deleted the update-nix-prefetch-github-2.4 branch June 26, 2020 13:49
@seppeljordan
Copy link
Contributor Author

@Ma27 Thank you for your feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seppeljordan @Ma27