Fix building of emacsWithPackages not findind subdirs.el #89351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It shouldn't hurt since we put the site-lisp in $deps, not $emacs. |
jian-lin
added a commit
to linj-fork/nixpkgs
that referenced
this pull request
Aug 26, 2023
I see no reason to symlink this dir. Doing so may shadow unwanted libraries since the site-start.el of Emacs adds paths under NIX_PROFILES to load-path. It is added in [1] to fix "building emacs". However, I have no issue in building and using Emacs after removing it. [1]: NixOS#89351
AndersonTorres
pushed a commit
that referenced
this pull request
Aug 28, 2023
I see no reason to symlink this dir. Doing so may shadow unwanted libraries since the site-start.el of Emacs adds paths under NIX_PROFILES to load-path. It is added in [1] to fix "building emacs". However, I have no issue in building and using Emacs after removing it. [1]: #89351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When building emacs, it complains of not finding
subdirs.elinemacs-packages-deps/share/emacs/site-lisp. Turns out that it is present as a broken sublink to the same file inemacs-with-packages, where the share subdirectory is full of links to the share subdirectory ofemacs, which included the desired file.I'm not sure if this fix is actually what we want, since the other file in
emacs-packages-deps/share/emacs/site-lispis shipped with nixpkgs, so maybe something similar should be done for subdirs. But adding the missing link step made it build, and emacs seems to work.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)