Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.tdlib: Fix system dependencies #89350

Closed
wants to merge 7 commits into from

Conversation

poscat0x04
Copy link
Contributor

Motivation for this change

Fix tdlib

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peti and others added 7 commits May 30, 2020 02:30
This update was generated by hackage2nix v2.15.3-1-gb7c82db from Hackage revision
commercialhaskell/all-cabal-hashes@17c20d2.
This update was generated by hackage2nix v2.15.3-1-gb7c82db from Hackage revision
commercialhaskell/all-cabal-hashes@1534356.
This update was generated by hackage2nix v2.15.3-1-gb7c82db from Hackage revision
commercialhaskell/all-cabal-hashes@9f2b109.
This update was generated by hackage2nix v2.15.3-1-gb7c82db from Hackage revision
commercialhaskell/all-cabal-hashes@9de0346.
Its tensorflow-mnist-data dependency is not on Hackage, and the
license conditions for the data are unclear.  Also, it's basically an
example package.
tensorflow-haskell: Remove tensorflow-mnist
@cdepillabout
Copy link
Member

@poscat0x04 Could you fix this in cabal2nix?

You'll have to send a PR adding tdjson to this list here:

https://github.com/NixOS/cabal2nix/blob/39f6c39f2a54fe97be07ea61cd127358283f903c/src/Distribution/Nixpkgs/Haskell/FromCabal/Name.hs#L16-L26

That way, we won't need to specifically add a fix for this here in nixpkgs.

@peti peti force-pushed the haskell-updates branch 3 times, most recently from 7a3d6f0 to ad62b57 Compare June 5, 2020 19:58
@poscat0x04
Copy link
Contributor Author

🎉

@poscat0x04 poscat0x04 closed this Jun 7, 2020
@poscat0x04 poscat0x04 deleted the fix-tdlib branch August 16, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants