Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] firmwareLinuxNonfree: 2020-01-22 -> 2020-05-19 #89311

Merged
merged 1 commit into from Jun 18, 2020
Merged

[20.03] firmwareLinuxNonfree: 2020-01-22 -> 2020-05-19 #89311

merged 1 commit into from Jun 18, 2020

Conversation

jsravn
Copy link
Contributor

@jsravn jsravn commented Jun 1, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fpletz June 1, 2020 15:13
@prusnak
Copy link
Member

prusnak commented Jun 1, 2020

This PR does not fit CONTRIBUTING.md

You should backport commit using git cherry-pick -x which makes it very easy to verify the change has been already merged to master first.

Also the PR title should start with [20.03] not [backport].

@prusnak prusnak added the 8.has: port to stable A PR already has a backport to the stable release. label Jun 1, 2020
@jsravn
Copy link
Contributor Author

jsravn commented Jun 1, 2020

Sorry! I did not see CONTRIBUTING.md initially. I see now it's sort of hidden in .github. I will update accordingly.

@jsravn jsravn changed the title [backport] firmwareLinuxNonfree: 2020-01-22 -> 2020-05-19 [20.03] firmwareLinuxNonfree: 2020-01-22 -> 2020-05-19 Jun 1, 2020
@jsravn jsravn force-pushed the backport-firmware-linux-nonfree branch from 39cf476 to 5cd1d38 Compare June 1, 2020 18:55
@jsravn
Copy link
Contributor Author

jsravn commented Jun 1, 2020

Okay, all done.

@jsravn
Copy link
Contributor Author

jsravn commented Jun 9, 2020

@prusnak can this be merged?

@prusnak
Copy link
Member

prusnak commented Jun 9, 2020

@jsravn I don't have permissions to do so, unfortunately

@jsravn
Copy link
Contributor Author

jsravn commented Jun 10, 2020

Ah okay. @fpletz then?

@worldofpeace worldofpeace merged commit f9b261c into NixOS:release-20.03 Jun 18, 2020
@worldofpeace
Copy link
Contributor

Thanks for backporting @jsravn ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsravn @prusnak @worldofpeace