Use text-decoration-thickness value in underline painting #23891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 1, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2218119
branch
10 times, most recently
from
3081e20
to
89fe925
Compare
Parsing of text-decoration-thickness was added in [1], use the parsed value in text decoration thickness painting. Add a WPT ref test that compares text-decoration-thickness value from a variable font (keyword value 'from-font' for text-decoration-thickness) with the identical rendering achieved by using a static font with thick and thin underline metadata. Add a second WPT ref test that compares a fixed text-decoration-thickness value to the from-font values of a font with thick and thin underlines. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2178888 Bug: 785230 Change-Id: I626a321a38c77e106215b640dcf85c20f7a0ad93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218119 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775116}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2218119
branch
from
89fe925
to
ca2d614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing of text-decoration-thickness was added in [1], use the parsed
value in text decoration thickness painting.
Add a WPT ref test that compares text-decoration-thickness value from a
variable font (keyword value 'from-font' for text-decoration-thickness)
with the identical rendering achieved by using a static font with thick
and thin underline metadata.
Add a second WPT ref test that compares a fixed
text-decoration-thickness value to the from-font values of a font with
thick and thin underlines.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2178888
Bug: 785230
Change-Id: I626a321a38c77e106215b640dcf85c20f7a0ad93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218119
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775116}