New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saucelabs: remove custom selenium version for Microsoft Edge #23895
Comments
@zouhir quick question - this code was developed when MicrosoftEdge meant EdgeHTML as far as I am aware. I assume Sauce now interprets 'MicrosoftEdge' as Chromium-based edge? |
This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes #23895
@stephenmcgruer I confirm your assumption is correct. I found this good reference for the support matrix in Webdriver+Saucelabs: https://wiki.saucelabs.com/display/DOCS/Platform+Configurator#/ MicrosoftEdge is used for both EdgeHTML and Chromium, the version decides which one to launch: |
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 Differential Revision: https://phabricator.services.mozilla.com/D78777
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 Differential Revision: https://phabricator.services.mozilla.com/D78777
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 Differential Revision: https://phabricator.services.mozilla.com/D78777
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 Differential Revision: https://phabricator.services.mozilla.com/D78777
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 UltraBlame original commit: 6419d0a1929a03ecdff8277391b079cdf690d799
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 Differential Revision: https://phabricator.services.mozilla.com/D78777 UltraBlame original commit: e31b0d2ecada5d458864f8a789138795ed283b25
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 Differential Revision: https://phabricator.services.mozilla.com/D78777 UltraBlame original commit: ca68e559f5c23350273d8afcc1d5044d3d905fe0
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 UltraBlame original commit: 6419d0a1929a03ecdff8277391b079cdf690d799
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 Differential Revision: https://phabricator.services.mozilla.com/D78777 UltraBlame original commit: e31b0d2ecada5d458864f8a789138795ed283b25
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 Differential Revision: https://phabricator.services.mozilla.com/D78777 UltraBlame original commit: ca68e559f5c23350273d8afcc1d5044d3d905fe0
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 UltraBlame original commit: 6419d0a1929a03ecdff8277391b079cdf690d799
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 Differential Revision: https://phabricator.services.mozilla.com/D78777 UltraBlame original commit: e31b0d2ecada5d458864f8a789138795ed283b25
…sets selenium version for edge, a=testonly Automatic update from web-platform-tests [Sauce] Remove workaround that manually sets selenium version for edge (#23897) This appears to be a leftover from the previous use of the sauce runner, assumedly when there was some bug that required a specific version of selenium to be used (it was sadly undocumented). Fixes web-platform-tests/wpt#23895 -- wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263 wpt-pr: 23897 Differential Revision: https://phabricator.services.mozilla.com/D78777 UltraBlame original commit: ca68e559f5c23350273d8afcc1d5044d3d905fe0
Currently, there seem to be a check for when the
--sauce-browser
passed in the runner CLI args is MicrosoftEdge and it makes it use older selenium version, I am not aware of any issues preventing Chromium based MS Edge to work onselenium@latest
so I believe it's safe to remove.wpt/tools/wptrunner/wptrunner/browsers/sauce.py
Line 72 in d3ea885
The text was updated successfully, but these errors were encountered: