Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saucelabs: remove custom selenium version for Microsoft Edge #23895

Closed
Tracked by #23898
zouhir opened this issue Jun 1, 2020 · 2 comments · Fixed by #23897
Closed
Tracked by #23898

Saucelabs: remove custom selenium version for Microsoft Edge #23895

zouhir opened this issue Jun 1, 2020 · 2 comments · Fixed by #23897
Labels

Comments

@zouhir
Copy link
Member

zouhir commented Jun 1, 2020

Currently, there seem to be a check for when the --sauce-browser passed in the runner CLI args is MicrosoftEdge and it makes it use older selenium version, I am not aware of any issues preventing Chromium based MS Edge to work on selenium@latest so I believe it's safe to remove.

if browser_name == 'MicrosoftEdge':

@stephenmcgruer
Copy link
Contributor

@zouhir quick question - this code was developed when MicrosoftEdge meant EdgeHTML as far as I am aware. I assume Sauce now interprets 'MicrosoftEdge' as Chromium-based edge?

stephenmcgruer added a commit that referenced this issue Jun 1, 2020
This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes #23895
@zouhir
Copy link
Member Author

zouhir commented Jun 1, 2020

@stephenmcgruer I confirm your assumption is correct.

I found this good reference for the support matrix in Webdriver+Saucelabs: https://wiki.saucelabs.com/display/DOCS/Platform+Configurator#/

MicrosoftEdge is used for both EdgeHTML and Chromium, the version decides which one to launch:
Screen Shot 2020-06-01 at 3 18 03 PM

stephenmcgruer added a commit that referenced this issue Jun 2, 2020
#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes #23895
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 8, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Jun 8, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 9, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

Differential Revision: https://phabricator.services.mozilla.com/D78777
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Jun 9, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

Differential Revision: https://phabricator.services.mozilla.com/D78777
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 10, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

Differential Revision: https://phabricator.services.mozilla.com/D78777
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Jun 10, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

Differential Revision: https://phabricator.services.mozilla.com/D78777
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Jun 11, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

UltraBlame original commit: 6419d0a1929a03ecdff8277391b079cdf690d799
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Jun 11, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

Differential Revision: https://phabricator.services.mozilla.com/D78777

UltraBlame original commit: e31b0d2ecada5d458864f8a789138795ed283b25
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Jun 11, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

Differential Revision: https://phabricator.services.mozilla.com/D78777

UltraBlame original commit: ca68e559f5c23350273d8afcc1d5044d3d905fe0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Jun 12, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

UltraBlame original commit: 6419d0a1929a03ecdff8277391b079cdf690d799
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Jun 12, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

Differential Revision: https://phabricator.services.mozilla.com/D78777

UltraBlame original commit: e31b0d2ecada5d458864f8a789138795ed283b25
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Jun 12, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

Differential Revision: https://phabricator.services.mozilla.com/D78777

UltraBlame original commit: ca68e559f5c23350273d8afcc1d5044d3d905fe0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Jun 12, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

UltraBlame original commit: 6419d0a1929a03ecdff8277391b079cdf690d799
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Jun 12, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

Differential Revision: https://phabricator.services.mozilla.com/D78777

UltraBlame original commit: e31b0d2ecada5d458864f8a789138795ed283b25
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Jun 12, 2020
…sets selenium version for edge, a=testonly

Automatic update from web-platform-tests
[Sauce] Remove workaround that manually sets selenium version for edge (#23897)

This appears to be a leftover from the previous use of the sauce runner,
assumedly when there was some bug that required a specific version of
selenium to be used (it was sadly undocumented).

Fixes web-platform-tests/wpt#23895
--

wpt-commits: d5aae4ab7f99e024f70aa0d93ca3748809995263
wpt-pr: 23897

Differential Revision: https://phabricator.services.mozilla.com/D78777

UltraBlame original commit: ca68e559f5c23350273d8afcc1d5044d3d905fe0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants