Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nslcd: pull in network-online.target #89323

Closed
wants to merge 1 commit into from
Closed

nixos/nslcd: pull in network-online.target #89323

wants to merge 1 commit into from

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jun 1, 2020

Motivation for this change

ldap queries require a network connection. It might be reasonable to backport this change to 20.03 as well...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested review from Mic92 and flokli June 1, 2020 19:35
@flokli
Copy link
Contributor

flokli commented Jun 1, 2020

How does the system behave while nslcd isn't yet active, but lookups happen?

@aanderse
Copy link
Member Author

aanderse commented Jun 1, 2020

In manual cases (like user logins) there isn't a problem: a query fails and then tries again. I ran into issues when having services (managed by systemd) depend on ldap users, though.

@flokli
Copy link
Contributor

flokli commented Jun 1, 2020

Yeah, I'd assume these things to be somewhat scary, but probably nothing we can fix here (at least as long as we don't have socket activation on such things ;-) )

@flokli
Copy link
Contributor

flokli commented Jun 1, 2020

I don't have an LDAP installation, so I'll leave it to @Mic92 to test and merge this.

@Mic92
Copy link
Member

Mic92 commented Jun 2, 2020

We discussed on IRC that it might be better to test if users.ldap.bind.policy = "hard_init"; might not solve network issues in a more general way.

@aanderse aanderse closed this Aug 1, 2020
@aanderse aanderse deleted the nslcd branch December 21, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @flokli @Mic92